Skip to content

Add Copilot instructions for CMSIS Core version sync enforcement#298

Merged
JonatanAntoni merged 4 commits into
mainfrom
copilot/add-copilot-instruction-file
Jun 1, 2026
Merged

Add Copilot instructions for CMSIS Core version sync enforcement#298
JonatanAntoni merged 4 commits into
mainfrom
copilot/add-copilot-instruction-file

Conversation

Copilot AI commented May 21, 2026

Copy link
Copy Markdown
Contributor
  • Review current .github/copilot-instructions.md
  • Locate Core/Core_A Doxygen config files and history tables
  • Update instructions to require synchronization with Core.dxy.in and Core_A.dxy.in
  • Update instructions to require changelog row checks in Core/src/history.md and Core_A/src/history.md
  • Clarify Cortex-R exception (no documentation synchronization required yet)
  • Validate changes

…nder

Agent-Logs-Url: https://github.com/ARM-software/CMSIS_6/sessions/487631cf-ec34-4ab8-9720-155ab97e8c40

Co-authored-by: JonatanAntoni <25795816+JonatanAntoni@users.noreply.github.com>
…its version macros

Agent-Logs-Url: https://github.com/ARM-software/CMSIS_6/sessions/57ccccea-30f1-4a2f-81b1-5691cfce0672

Co-authored-by: JonatanAntoni <25795816+JonatanAntoni@users.noreply.github.com>
Copilot AI requested a review from JonatanAntoni May 21, 2026 11:57
@JonatanAntoni JonatanAntoni requested review from Copilot and soumeh01 May 21, 2026 12:10
@JonatanAntoni JonatanAntoni marked this pull request as ready for review May 21, 2026 12:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds repository-specific Copilot code review guidance to enforce CMSIS Core version synchronization between the PDSC component metadata and the corresponding cmsis_version.h macros.

Changes:

  • Introduces CMSIS Core version consistency rules for code reviews.
  • Maps ARM.CMSIS.pdsc CORE component condition values to the correct __CM_ / __CA_ / __CR_ macro prefixes.
  • Documents a per-profile (A/M/R) verification checklist and example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/copilot-instructions.md Outdated
Comment thread .github/copilot-instructions.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@soumeh01 soumeh01 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonatanAntoni JonatanAntoni merged commit 89ce607 into main Jun 1, 2026
1 check passed
@JonatanAntoni JonatanAntoni deleted the copilot/add-copilot-instruction-file branch June 1, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants